Most planes mentioned are pretty good and they can all make a decent profit.
With me it comes down more to availability. I've used the An-140 in the past but it's not available until the early 90s. By then I've usually invested pretty heavily in something else so they're usually not an option.
The same's true in reverse. I like ATPs and am currently flying 120 of them but they're getting old and the line is closed. So, I'll have to switch them all to something else before end of game so I'm thinking I may have been better going for something like the ATR, which will be in production right to the end.
Others not yet mentioned which are good:
F27 - available very early (late 50s) and beat the spots off anything around at the time. Good for 30+ years.
Fokker 50 - still pretty good, but probably not as good as others available by the 90s
HS748 - Again, very good in their heyday but won't be available later. Still, useful from the 60s right through to the early 80s. A bit slow though.
YS-11 - not great, but the biggest in this class. Still make a decent profit.
Just remembered, tlaking of size - another thing to consider - the "arbitrary" limit on C class seating being available. No C class allowed in the F27/Fokker 50 because it's too small but you can in the HS748, Xian, YS-11, Saab. I think the An-140 suffers from the same problem iirc. Depends if you nead that feature really.